Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Computed.dispose() method, which disposes existing cached value #859

Closed
fzyzcjy opened this issue Sep 4, 2022 · 1 comment · Fixed by #894
Closed

Add Computed.dispose() method, which disposes existing cached value #859

fzyzcjy opened this issue Sep 4, 2022 · 1 comment · Fixed by #894

Comments

@fzyzcjy
Copy link
Collaborator

fzyzcjy commented Sep 4, 2022

No description provided.

@fzyzcjy fzyzcjy mentioned this issue Sep 4, 2022
Closed
7 tasks
@fzyzcjy
Copy link
Collaborator Author

fzyzcjy commented Sep 4, 2022

Would be great if someone could review a bit about PR for this issue - I want to mimic _suspend for dispose(), is it reasonable? Or we will have trouble when calling _context._clearObservables(this);?

fzyzcjy added a commit to fzyzcjy/mobx.dart that referenced this issue Sep 4, 2022
@fzyzcjy
feat: add Computed.dispose mobxjs#859
20fe5d3
fzyzcjy added a commit to fzyzcjy/mobx.dart that referenced this issue Sep 6, 2022
@fzyzcjy
Revert "feat: add Computed.dispose mobxjs#859"
3912572 
This reverts commit 20fe5d3.
@amondnet amondnet mentioned this issue Jan 27, 2023
Merged
7 tasks
amondnet added a commit that referenced this issue Feb 16, 2023
@amondnet @fzyzcjy
gh-844 (#894)
d99a5c6 
* add `nonObservableInner`, such that users can bypass observability system for performance

* chore: format code

* feat: Add `onDispose` callback to `Computed`, such that old values can be properly disposed #857

* test: add tests to `disposeValue` #857

* test: add tests for "Allow users to bypass observability system for performance"

* feat: add `Computed.dispose` #859

* test: add tests for Computed.dispose

* test: reproduce #855

* fix: Avoid unnecessary observable notifications of `@observable` fields of `Store`s #855

* Revert "test: add tests for Computed.dispose"

This reverts commit 63d57ef.

* Revert "feat: add `Computed.dispose` #859"

This reverts commit 20fe5d3.

* Revert "test: add tests to `disposeValue` #857"

This reverts commit 263155b.

# Conflicts:
#	mobx/test/computed_test.dart

* Revert "feat: Add `onDispose` callback to `Computed`, such that old values can be properly disposed #857"

This reverts commit bbd9020.

* format code and minor change to code

* add Observable.nonObservableValue

* fix: Reaction lacks toString, so cannot see which reaction causes the error #864

* feat: Add StackTrace to reactions in debug mode to easily spot which reaction it is #864

* fix linter errors

* add toString and debugCreationStack

* test: add atom_test

---------

Co-authored-by: fzyzcjy <ch271828n@outlook.com>
Co-authored-by: fzyzcjy <5236035+fzyzcjy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@fzyzcjy