Feat: Allow a custom equals parameter for ObservableStream #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for mobx failed.
|
Codecov Report
@@ Coverage Diff @@
## master #771 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 55 55
Lines 1920 1923 +3
=======================================
+ Hits 1899 1902 +3
Misses 21 21
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
amondnet
force-pushed
the
custom-equals-stream
branch
from
c2bc0e8
to
35aea22
Compare
amondnet
changed the title
pavanpodila
requested changes
Mar 21, 2022
pavanpodila
requested changes
Apr 21, 2022
amondnet
force-pushed
the
custom-equals-stream
branch
from
35aea22
to
8029688
Compare
amondnet
force-pushed
the
custom-equals-stream
branch
from
f9644fd
to
4b5119a
Compare
|
Can you resolve conflicts pls before the merge. Also will need to bump up the version for publishing and add to changelog |
Signed-off-by: Minsu Lee <amond@amond.net>
amondnet
force-pushed
the
custom-equals-stream
branch
from
97521ab
to
e7b88a9
Compare
Signed-off-by: Minsu Lee <amond@amond.net>
|
@pavanpodila Done. |
pavanpodila
requested changes
Sep 19, 2022
| @@ -332,7 +345,8 @@ class _ObservableStreamController<T> { | |||
| name: '$name.status'), | |||
| _valueType = Observable(_ValueType.value, | |||
| context: context, name: '$name.valueType'), | |||
| _data = Observable(initialValue, context: context, name: '$name.data') { | |||
| _data = Observable<dynamic>(initialValue, | |||
There was a problem hiding this comment.
Yes, I would like to use Observable<T?>, but Object type is assigned inside the _onError function.
void _onError(Object error) {
final actionInfo = _actions.startAction();
try {
_status.value = StreamStatus.active;
_valueType.value = _ValueType.error;
_data.value = error;
} finally {
_actions.endAction(actionInfo);
_tryInsertInitialValue();
_controller.addError(error);
}
}
pavanpodila
approved these changes
Oct 12, 2022
tlvenn
pushed a commit
to magelo-labs/mobx.dart_old
that referenced
this pull request
Dec 31, 2022
* feat: allow a custom equals parameter for ObservableStream Signed-off-by: Minsu Lee <amond@amond.net> * feat: allow a custom equals parameter for ObservableStream Signed-off-by: Minsu Lee <amond@amond.net> Signed-off-by: Minsu Lee <amond@amond.net> Co-authored-by: Pavan Podila <pavanpodila@users.noreply.github.com>
tlvenn
pushed a commit
to magelo-labs/mobx.dart_old
that referenced
this pull request
Dec 31, 2022
* feat: allow a custom equals parameter for ObservableStream Signed-off-by: Minsu Lee <amond@amond.net> * feat: allow a custom equals parameter for ObservableStream Signed-off-by: Minsu Lee <amond@amond.net> Signed-off-by: Minsu Lee <amond@amond.net> Co-authored-by: Pavan Podila <pavanpodila@users.noreply.github.com>
|
@all-contributors please add @amondnet for doc |
|
I've put up a pull request to add @amondnet! 🎉 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a custom equals parameter for
ObservableStream, like what exists already forObservable.Currently,
ObservableStreamuses == to determine if the value changed. This creates an option to override that with a different EqualityComparator.mobx.dart/mobx/lib/src/api/async/observable_stream.dart
Line 439 in f8677da
mobx.dart/mobx/lib/src/core/observable.dart
Line 62 in f8677da
mobx.dart/mobx/lib/src/core/observable.dart
Line 106 in f8677da
#679