test: action should wrap in transaction #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mobx canceled.
|
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
=======================================
Coverage 98.96% 98.96%
=======================================
Files 55 55
Lines 1924 1924
=======================================
Hits 1904 1904
Misses 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
amondnet
force-pushed
the
test-action_should_wrap_in_transaction
branch
from
0cd860f
to
5f97c5d
Compare
|
Hi all, What's stopping this from being merged at the moment? Thanks, |
amondnet
force-pushed
the
test-action_should_wrap_in_transaction
branch
from
5f97c5d
to
081bf49
Compare
Signed-off-by: Minsu Lee <amond@amond.net>
amondnet
force-pushed
the
test-action_should_wrap_in_transaction
branch
from
081bf49
to
f6da5c1
Compare
pavanpodila
reviewed
Jan 27, 2023
| @@ -327,5 +327,23 @@ void main() { | |||
|
|
|||
| d(); | |||
| }); | |||
|
|
|||
| test('action should wrap in transaction', () { | |||
There was a problem hiding this comment.
Since a new test is introduced. Let's add a PR for version bump and changelog entry @amondnet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Minsu Lee amond@amond.net
https://github.com/mobxjs/mobx/blob/63698d0681988194bac5fc01851882b417b35f18/packages/mobx/__tests__/v5/base/action.js#L4
Pull Request Checklist
pubspec.yamlis updated.major/minor/patch/patch-count, depending on the complexity of changeset:versionscommand usingnpmoryarn. You can find this command in thepackage.jsonfile in the root directory