Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor atom.dart to make code cleaner #854

Merged
merged 6 commits into from
Feb 3, 2023
Merged

Refactor atom.dart to make code cleaner #854

merged 6 commits into from
Feb 3, 2023

Conversation

fzyzcjy
Copy link
Collaborator

@fzyzcjy fzyzcjy commented Sep 4, 2022

Describe the changes proposed in this Pull Request.

If the PR fixes a specific issue, reference the issue with Fixes #.


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR
  • Run the set:versions command using npm or yarn. You can find this command in the package.json file in the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

@netlify
Copy link

netlify bot commented Sep 4, 2022

Deploy Preview for mobx canceled.

Name Link
🔨 Latest commit 09edd47
🔍 Latest deploy log https://app.netlify.com/sites/mobx/deploys/637112aae2e59d00099541f1

@codecov
Copy link

codecov bot commented Sep 4, 2022

Codecov Report

Merging #854 (9ef80aa) into master (13b7e6d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #854      +/-   ##
==========================================
- Coverage   98.96%   98.95%   -0.01%     
==========================================
  Files          55       55              
  Lines        1924     1922       -2     
==========================================
- Hits         1904     1902       -2     
  Misses         20       20              
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.53% <100.00%> (-0.01%) ⬇️
mobx_codegen 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mobx/lib/src/core/atom.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13b7e6d...9ef80aa. Read the comment docs.

@pavanpodila
Copy link
Member

Why is the code coverage dropping here? Can you please check

@fzyzcjy
Copy link
Collaborator Author

fzyzcjy commented Sep 4, 2022

No idea... It looks equivalent indeed

image

Copy link
Collaborator

@amondnet amondnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pavanpodila pavanpodila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but need version change on pubspec, NPM set:versions and changelog

mobx/lib/src/core/atom.dart Show resolved Hide resolved
@ghenry
Copy link

ghenry commented Dec 19, 2022

Hi all,

This looks good to merge and close?

Thanks.

@amondnet amondnet self-assigned this Jan 27, 2023
@amondnet amondnet merged commit 4400ea1 into master Feb 3, 2023
@amondnet amondnet deleted the fzyzcjy-patch-1 branch February 3, 2023 17:34
@amondnet
Copy link
Collaborator

@all-contributors please add @amondnet for review

@allcontributors
Copy link
Contributor

@amondnet

I've put up a pull request to add @amondnet! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants