-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix tests in dart 2.19 #879
Conversation
✅ Deploy Preview for mobx canceled.
|
Codecov Report
@@ Coverage Diff @@
## master #879 +/- ##
===========================================
- Coverage 100.00% 98.95% -1.05%
===========================================
Files 5 55 +50
Lines 97 1923 +1826
===========================================
+ Hits 97 1903 +1806
- Misses 0 20 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except the codecov
7a904b2
to
318f1a9
Compare
Would be great to see this merged as it's holding up: #877. Thanks! |
Hey can someone please merge this already? It's really holding up our project as we cannot update to freezed 2.2.1 with a critical bug fix. |
5f7d132
to
c6e238c
Compare
Any update on this?? |
news? |
* test: fix tests in dart 2.19 * test: fix tests in dart 2.19 * test: fix tests in dart 2.19
* test: fix tests in dart 2.19 * test: fix tests in dart 2.19 * test: fix tests in dart 2.19
Describe the changes proposed in this Pull Request.
If the PR fixes a specific issue, reference the issue with
Fixes #
.Dart 2.19 doesn't delegate inaccessible private names to noSuchMethod.
https://github.com/dart-lang/sdk/blob/main/CHANGELOG.md#2190
dart-lang/language#2020
dart-lang/sdk#49687
dart-lang/site-www#4263
https://github.com/mobxjs/mobx.dart/blob/master/mobx/test/observable_test.dart
The test fails on dart 2.19.
https://github.com/mobxjs/mobx.dart/actions/runs/3262020308/jobs/5359681093
Pull Request Checklist
pubspec.yaml
is updated.major
/minor
/patch
/patch-count
, depending on the complexity of changemelo run set_version
command from the root directory