Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require analyzer: ^5.12.0 #934

Merged
merged 4 commits into from
Sep 19, 2023
Merged

feat: require analyzer: ^5.12.0 #934

merged 4 commits into from
Sep 19, 2023

Conversation

amondnet
Copy link
Collaborator

@amondnet amondnet commented Sep 15, 2023

Describe the changes proposed in this Pull Request.

If the PR fixes a specific issue, reference the issue with Fixes #.

Fixes #928
Fixes #929
Fixes #930


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melo run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

@amondnet amondnet self-assigned this Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #934 (69a73c1) into master (6e6378c) will not change coverage.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #934   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files          56       56           
  Lines        1987     1987           
=======================================
  Hits         1967     1967           
  Misses         20       20           
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.55% <ø> (ø)
mobx_codegen 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
mobx_codegen/lib/src/template/util.dart 100.00% <ø> (ø)
mobx_codegen/lib/src/type_names.dart 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c1506...69a73c1. Read the comment docs.

@amondnet amondnet changed the title feat: require analyzer: '>=4.4.0 <6.2.0' feat: require analyzer: ^5.12.0 Sep 15, 2023
This was linked to issues Sep 15, 2023
@HudsonAfonso
Copy link

@pavanpodila, @fzyzcjy news?

Copy link
Collaborator

@fzyzcjy fzyzcjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (since just a simple migration of APIs)

@amondnet amondnet merged commit 9a97f09 into mobxjs:master Sep 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: analyzer ^6.2.0 Support for analyzer 6.0.0
3 participants