Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary observable notifications of Iterable or Map fields #951

Merged
merged 5 commits into from
Dec 4, 2023

Conversation

amondnet
Copy link
Collaborator

@amondnet amondnet commented Nov 2, 2023

Describe the changes proposed in this Pull Request.

Following up on pr #844, perform deep equals if value is Iterable or Map.


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melos run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #951 (51e1462) into main (a00d4da) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 51e1462 differs from pull request most recent head 5281253. Consider uploading reports for the commit 5281253 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #951      +/-   ##
==========================================
- Coverage   99.00%   98.99%   -0.01%     
==========================================
  Files          57       57              
  Lines        2000     1997       -3     
==========================================
- Hits         1980     1977       -3     
  Misses         20       20              
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.56% <100.00%> (+<0.01%) ⬆️
mobx_codegen 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
mobx/lib/src/core/atom_extensions.dart 100.00% <100.00%> (ø)
mobx/lib/src/core/observable.dart 100.00% <100.00%> (ø)
mobx/lib/src/utils.dart 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a00d4da...5281253. Read the comment docs.

@amondnet amondnet added this to the mobx-2.2.2 milestone Nov 2, 2023
@amondnet amondnet added the enhancement New feature or request label Nov 2, 2023
@amondnet amondnet marked this pull request as ready for review November 2, 2023 14:55
Copy link

netlify bot commented Nov 24, 2023

👷 Deploy request for mobx pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5281253

@pavanpodila
Copy link
Member

Will need to go to 2.2.3 as a previous PR took that version @amondnet

@amondnet amondnet reopened this Dec 4, 2023
@amondnet
Copy link
Collaborator Author

amondnet commented Dec 4, 2023

@pavanpodila done

@amondnet amondnet removed this from the mobx-2.2.2 milestone Dec 4, 2023
@pavanpodila pavanpodila merged commit d14a27e into mobxjs:main Dec 4, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants