Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds useDeepEquality for creating observables #971

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

amondnet
Copy link
Collaborator

@amondnet amondnet commented Dec 18, 2023

Describe the changes proposed in this Pull Request.

Make the change in 2.2.3 optional. If you want the use this behavior , modify @observable to @MakeObservable(useDeepEquality: true).

Fixes #969


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melos run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

Copy link

netlify bot commented Dec 18, 2023

👷 Deploy request for mobx pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 33c8881

@amondnet amondnet self-assigned this Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #971 (2faae45) into main (52515a1) will decrease coverage by 0.10%.
The diff coverage is 80.00%.

❗ Current head 2faae45 differs from pull request most recent head 33c8881. Consider uploading reports for the commit 33c8881 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #971      +/-   ##
==========================================
- Coverage   99.00%   98.90%   -0.10%     
==========================================
  Files          57       57              
  Lines        2005     2006       +1     
==========================================
- Hits         1985     1984       -1     
- Misses         20       22       +2     
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.42% <75.00%> (-0.15%) ⬇️
mobx_codegen 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
mobx/lib/src/api/annotations.dart 80.00% <100.00%> (ø)
mobx/lib/src/core/atom_extensions.dart 100.00% <100.00%> (ø)
mobx_codegen/lib/src/template/observable.dart 100.00% <100.00%> (ø)
mobx/lib/src/utils.dart 81.81% <50.00%> (-18.19%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52515a1...33c8881. Read the comment docs.

@amondnet amondnet changed the title feat: Adds useEquatable for creating observables feat: Adds useDeepEquality for creating observables Dec 18, 2023
@amondnet amondnet force-pushed the useEquatable branch 2 times, most recently from 2faae45 to 1a7b0e3 Compare December 18, 2023 08:24
Make the change in 2.2.3 optional. If you want the use this behavior , modify `@observable` to `@MakeObservable(useEquatable: true)`.
Copy link
Member

@pavanpodila pavanpodila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavanpodila pavanpodila merged commit 827bb5d into mobxjs:main Dec 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ObservableMap not notifying Observer mobx 2.2.3 it was woking fine in 2.2.1
2 participants