Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support late observables #973

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

amondnet
Copy link
Collaborator

@amondnet amondnet commented Dec 19, 2023

Describe the changes proposed in this Pull Request.

Fixes #919


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melos run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for mobx canceled.

Name Link
🔨 Latest commit 1b5d3fc
🔍 Latest deploy log https://app.netlify.com/sites/mobx/deploys/658bb2b972a65b000860fe8e

@amondnet amondnet self-assigned this Dec 19, 2023
@amondnet amondnet added the enhancement New feature or request label Dec 19, 2023
@amondnet amondnet marked this pull request as draft December 19, 2023 09:33
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (60f07a0) 99.00% compared to head (1b5d3fc) 99.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #973   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files          57       57           
  Lines        2006     2017   +11     
=======================================
+ Hits         1986     1997   +11     
  Misses         20       20           
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.56% <ø> (ø)
mobx_codegen 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
mobx_codegen/lib/src/store_class_visitor.dart 100.00% <100.00%> (ø)
mobx_codegen/lib/src/template/observable.dart 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60f07a0...1b5d3fc. Read the comment docs.

@amondnet amondnet marked this pull request as ready for review December 19, 2023 09:35
@amondnet amondnet force-pushed the 919-support-late-observables branch 3 times, most recently from 9273525 to 8525199 Compare December 19, 2023 09:43
Copy link
Member

@pavanpodila pavanpodila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ... need to resolve conflicts and version bumps

@amondnet
Copy link
Collaborator Author

@pavanpodila I rebased to the main branch and resolved the conflict.

@pavanpodila pavanpodila enabled auto-merge (squash) December 27, 2023 05:17
@pavanpodila pavanpodila merged commit 00fe8b0 into mobxjs:main Dec 27, 2023
14 checks passed
@amondnet amondnet added this to the mobx_codegen-2.5.0 milestone Dec 27, 2023
@amondnet amondnet deleted the 919-support-late-observables branch December 27, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support late observables
2 participants