fix (#3257)

mobxjs · Jan 5, 2022 · 654a201 · 654a201
1 parent 40ad091
commit 654a201
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/.changeset/silly-lions-run.md b/.changeset/silly-lions-run.md
@@ -0,0 +1,5 @@
+---
+"mobx": patch
+---
+
+fix: observable map initialization violates `enforceActions: "always"`
diff --git a/packages/mobx/__tests__/v5/base/map.js b/packages/mobx/__tests__/v5/base/map.js
@@ -8,7 +8,9 @@ import {
     computed,
     action,
     when,
-    runInAction
+    runInAction,
+    configure,
+    _resetGlobalState
 } from "../../../src/mobx.ts"
 
 const map = mobx.observable.map
@@ -1335,3 +1337,13 @@ test("2346 - subscribe to not yet existing map keys", async () => {
     await when(() => events.length > 1)
     expect(events).toEqual([42, 84])
 })
+
+test('initialization should not violate `enforceActions: "always"` - discussion #3255', async () => {
+    const consoleWarnSpy = jest.spyOn(console, "warn").mockImplementation(() => {
+        throw new Error("console.warn called")
+    })
+    configure({ enforceActions: "always" })
+    observable(new Map([["x", "x"]]))
+    _resetGlobalState()
+    consoleWarnSpy.mockRestore()
+})
diff --git a/packages/mobx/src/types/observablemap.ts b/packages/mobx/src/types/observablemap.ts
@@ -34,7 +34,8 @@ import {
     isFunction,
     UPDATE,
     IAtom,
-    PureSpyEvent
+    PureSpyEvent,
+    allowStateChanges
 } from "../internal"
 
 export interface IKeyValueMap<V = any> {
@@ -107,7 +108,9 @@ export class ObservableMap<K = any, V = any>
         this.keysAtom_ = createAtom(__DEV__ ? `${this.name_}.keys()` : "ObservableMap.keys()")
         this.data_ = new Map()
         this.hasMap_ = new Map()
-        this.merge(initialData)
+        allowStateChanges(true, () => {
+            this.merge(initialData)
+        })
     }
 
     private has_(key: K): boolean {