Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.0-beta.2] ReferenceError: fail is not defined #1376

Closed
heikkilamarko opened this issue Mar 8, 2018 · 1 comment
Closed

[4.0.0-beta.2] ReferenceError: fail is not defined #1376

heikkilamarko opened this issue Mar 8, 2018 · 1 comment

Comments

@heikkilamarko
Copy link

I migrated my project to use 4.0.0-beta.2. When using extendObservable, I receive the following error:

ReferenceError: fail is not defined

I took a look at the MobX source code and found the possible reason:

In action.ts file, and in the following line:

arg1[arg2] = createAction(name, arg3.value)

name is not defined. Should this be something like:

arg1[arg2] = createAction(arg1.name || "<unnamed action>", arg3.value)

mweststrate added a commit that referenced this issue Mar 8, 2018
@mweststrate
Copy link
Member

Thanks for reporting! Fixed in mobx@4.0.0-beta.3 (this will probably result in some peer dep errors, but you can ignore these)

@mweststrate mweststrate mentioned this issue Mar 8, 2018
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants