Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Flow typings at mobx@4.2.0 #1520

Closed
andrew--r opened this issue Apr 24, 2018 · 0 comments
Closed

Invalid Flow typings at mobx@4.2.0 #1520

andrew--r opened this issue Apr 24, 2018 · 0 comments

Comments

@andrew--r
Copy link
Contributor

andrew--r commented Apr 24, 2018 •
edited
Loading

I have an issue with mobx@4.2.0. It has invalid flow type annotation for configure options. Here is reproduction.

The problem is that interface properties in Flow are invariant, so enforceActions?: boolean | "strict" doesn't work, we need to make this property covariant (+enforceActions?: boolean | "strict"). Here is a correct implementation example.

PR with a fix: #1521
mweststrate added a commit that referenced this issue Apr 26, 2018
@mweststrate
Merge pull request #1521 from andrew--r/patch-1
91c2ea4 
[Flow typings] Make `enforceActions` property covariant (fixes #1520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrew--r