WIP: MobX 5 #1380
Closed
WIP: MobX 5 #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
benjamingr
reviewed
Mar 12, 2018
| @@ -16,6 +16,12 @@ | |||
| * | |||
| */ | |||
|
|
|||
| if (typeof Proxy === "undefined") { | |||
| throw new Error( | |||
tkrotoff
reviewed
Mar 12, 2018
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "mobx", | |||
| "version": "4.0.0-beta.4", | |||
| "version": "15.0.0-alpha.1", | |||
There was a problem hiding this comment.
Actually might be 15 :-) .Completely in the spirit of React.
But more importantly, I want to keep supporting MobX 4 for those we have to support browsers without proxies. And calling this one 5 would hamper the ability to make breaking changes on the "4-branch"
There was a problem hiding this comment.
I mean i have no objection, it's just a bit mind bending ^^
Fix flow typings
Added something missing from the CHANGELOG
|
Not sure if it is relevant, I really don't care or know exactly which
versions of browsers are supported, browser doesn't really matter, only
thing that is interesting is that the engine supports Proxy. From that
point on the browser will most probably be supported for a very long time
Op ma 4 jun. 2018 om 16:46 schreef Bnaya Peretz <notifications@github.com>:
… ***@***.**** commented on this pull request.
------------------------------
In CHANGELOG.md
<#1380 (comment)>:
> @@ -1,16 +1,88 @@
+# 5.0.0
+
+* The minimum runtime target is now ES2015, not ES5
you also have granularity of last 2 major versions of edge, chrome,
safari, and so
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1380 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABvGhM96TniGgenm1BQInc86ERghOWGiks5t5UgsgaJpZM4SiySn>
.
|
adds Browser support section to the main readme
@computed({keepAlive: true}) no long calculates before being accessed
…the correct usage
|
bugfix: allow changing while observable array initialization
benjamingr
reviewed
Jun 5, 2018
CHANGELOG.md
Outdated
|
|
||
| ### Known Issues | ||
|
|
||
| * Jest `toEqual` might throw an error `allKeys[x].match is not a function` when trying to equal observable arrays. This is a bug in Jest [report](https://github.com/facebook/jest/issues/6391). The simple work around for now is to slice (or `toJS` if the problem is recursive) the array first. |
There was a problem hiding this comment.
This was merged into jest - so update to "older versions of jest"?
benjamingr
reviewed
Jun 5, 2018
CHANGELOG.md
Outdated
| ### Known Issues | ||
|
|
||
| * Jest `toEqual` might throw an error `allKeys[x].match is not a function` when trying to equal observable arrays. This is a bug in Jest [report](https://github.com/facebook/jest/issues/6391). The simple work around for now is to slice (or `toJS` if the problem is recursive) the array first. | ||
| * Jest `toEqual` matcher might no longer corretly equal your class instances, complaining about differences in the MobX adminstration. This is due to a bug with the processing of symbols: [report](https://github.com/facebook/jest/issues/6392). For now you might want to use a custom matcher if you are directly equalling observable objects. As a work around `toJS(object)` could be used before diffing. |
|
Released! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing to see here yet
ObservableMap extends MapNot supported by TS / babelreportObservedrecording using sets?releaseMeh. Just mobx 5 should be finemobx 5which always throws: pick mobx 4 or 15introducesealoption?proxy: falseis a new option instead