Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill symbols in set, map and array alike #1880

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Polyfill symbols in set, map and array alike #1880

merged 1 commit into from
Jan 24, 2019

Conversation

nykula
Copy link
Contributor

@nykula nykula commented Jan 23, 2019

Fixes #1878, an omission in Set backport. Reuses existing utils. Should restore IE11 compatibility.

  • Added unit tests Can't, tests use modern Node which has an okay Symbol.
  • Updated changelog Not creating a new version myself. Or should I write log anyway?
  • Updated docs (either in the description of this PR as markdown <- this, or as separate PR on the gh-pages branch. Please refer to this PR). For new functionality, at least API.md should be updated
  • Added typescript typings Regression fix, no API change.
  • Verified that there is no significant performance drop (npm run perf npm run test:performance)

Fixes #1878, an omission in Set backport. Reuses existing utils. Should
restore IE11 compatibility.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 92.335% when pulling d064453 on makepost:mobx4-master into 191c71f on mobxjs:mobx4-master.

@mweststrate mweststrate merged commit 5e3aa1d into mobxjs:mobx4-master Jan 24, 2019
@mweststrate
Copy link
Member

Thanks! Will release soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants