-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update tooling (rollup, etc) (ignore red x, it is coveralls) #1931
Conversation
@xaviergonz in the category of "if it ain't broken, don't fix it", any special highlights that make it important to merge this? In general I don't have any trouble swapping tools around, but in MobX's case it is a little bit more trickier, since every change on master is cherry-picked to the mobx4 branch, it is really valuable to not touch or divert too many things (or, obviously, do it on both). That is for example the reason why the tests are all still in |
I think I'm just asking, how hard is it to do the same on the mobx4-master branch 🙈 |
windows compatibility mostly :) It is a bit annoying to be forced to switch to WSL just to work on mobx. Also using terser for minification I'd say is a big plus, since uglifyJs has had bugs that haven't been fixed in like... forever, and those have bitten me more than once in production versions, while I still haven't had a single issue with terser. How hard? dunno, I could try to cherry pick it into the mobx4 branch and see what happens? |
Yeah, feel free
…On Wed, Apr 17, 2019 at 3:56 PM Javier Gonzalez ***@***.***> wrote:
windows compatibility mostly :) It is a bit annoying to be forced to
switch to WSL just to work on mobx.
Also using terser for minification I'd say is a big plus, since uglifyJs
has had bugs that haven't been fixed in like... forever, and those have
bitten me more than once in production versions, while I still haven't had
a single issue with terser.
How hard? dunno, I could try to cherry pick it into the mobx4 branch and
see what happens?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1931 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABvGhCuMLQm8CzhoQRL0AXhaR93EOanOks5vhygDgaJpZM4b4rjH>
.
|
Similar pr open for mobx 4 |
Merged! Thanks! |
This kind of big PR is all about tooling:
no actual source code was changed other than tests (AFAI remember) :)
note that the decrease in coverage is most probably the update of jest doing a better job at detecting uncovered lines