FIxed typings (function properties instead of methods in decorators) #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added computed.shallow decorator
|
|
mweststrate
requested changes
Aug 26, 2020
There was a problem hiding this comment.
Thanks for making this PR! However, please open a separate PR per issue. I'm fine merging the TS arrow fn changes right away, but for the computed.shallow see the issue. In any case PRs ideally address only a single issue :) to simplify issue tracking / reporting / reverting
Amareis
changed the title
|
I think .prettierrc should be updated on master :D |
mweststrate
approved these changes
Sep 17, 2020
|
Merging, thanks again! |
|
Released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2438
Code change checklist
/docs. For new functionality, at leastAPI.mdshould be updatednpm run perf)