Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safeDescriptors to configure options type #2763

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Add safeDescriptors to configure options type #2763

merged 1 commit into from
Jan 29, 2021

Conversation

vkrol
Copy link
Contributor

@vkrol vkrol commented Jan 29, 2021

This is the follow-up to #2761 🙂 It was missed in the original PR. /cc @urugator

Code change checklist

  • Added/updated unit tests
  • Updated /docs. For new functionality, at least API.md should be updated
  • Verified that there is no significant performance drop (npm run perf)

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2021

🦋 Changeset detected

Latest commit: 5398301

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mobx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielkcz
Copy link
Contributor

Add changeset, please.

@urugator
Copy link
Collaborator

Damit, thank you! Since it was already released, I assume this one will have to be released as another verison, can you please add changeset?
yarn changeset
spacebar to select
enter to confirm
:)

@vkrol
Copy link
Contributor Author

vkrol commented Jan 29, 2021

I forgot about changset again 🤦 Thanks!

@danielkcz danielkcz merged commit d2a2a52 into mobxjs:main Jan 29, 2021
@github-actions github-actions bot mentioned this pull request Jan 29, 2021
@vkrol vkrol deleted the add-safeDescriptors-to-configure-options-type branch January 29, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants