Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parseTsAsNonJsx flag for mobx-undecorate #2785

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

iChenLei
Copy link
Member

@iChenLei iChenLei commented Feb 5, 2021

Code change checklist

  • Added/updated unit tests
  • Updated /docs. For new functionality, at least API.md should be updated
  • Verified that there is no significant performance drop (npm run perf)

PR Target

fix #2754

Summary

Add a new cli flag parseTsAsNonJsx, If add the flag we will parse ts file as non-jsx and other files as same as before.

npx mobx-undecorate --parseTsAsNonJsx

@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2021

🦋 Changeset detected

Latest commit: f0fa408

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mobx-undecorate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iChenLei iChenLei requested a review from mweststrate February 5, 2021 08:05
Copy link
Member

@mweststrate mweststrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks for picking this up!

@danielkcz danielkcz merged commit c6b1c5d into mobxjs:main Feb 5, 2021
@github-actions github-actions bot mentioned this pull request Feb 5, 2021
@iChenLei iChenLei deleted the parseTsAsNonJsx branch February 5, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mobx-undecorate] need option to treat parse ts file as non-jsx
4 participants