Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement options for making
computed
s andreactions
/autoruns
garbage-collectable without manually disposing them.I've had a couple apps that I've needed to use
keepAlive
computed
s. I'm lazy and can't make promises that future me/future my app will dispose them properly. Now that JS supportsWeakRef
s, this is a less of a problem. The use case is pretty slim, mainly aroundcomputed(() => {}, { keepAlive: true })
stuff, but it can be used forautoruns
too (though you'll need to keep a reference to theautorun
in some other way less it fall out of scope and get garbage collected)./docs
. For new functionality, at leastAPI.md
should be updatedyarn mobx test:performance
)