Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix devDependencies version duplication in monorepo #3897

Closed
wants to merge 1 commit into from

Conversation

vovsemenv
Copy link

This PR fix some problems with deps versions in monorepo
Linted via https://www.npmjs.com/package/sherif

  mobx git:(main) npx sherif --fix
✓ Select the version of @babel/core to use: ^7.16.0   ↑ highest
✓ Select the version of @babel/preset-env to use: ^7.16.4   ↑ highest

1 issue found in ./package.json:

 ⨯ error The root package.json should specify the package manager and version to use. Useful for tools like corepack. root-package-manager-field
  │ {
  +   "packageManager": "..."   ← missing packageManager field.
  │ }

1 issue found in ./packages/mobx/package.json:

 ✓ fixed package.json should not have empty dependencies fields. empty-dependencies
  │ {
  -   "dependencies": {}   ← field is empty.
  │ }

2 issues found in ./:

 ✓ fixed Dependency @babel/core has multiple versions defined in the workspace. multiple-dependency-versions
  ./packages
      mobx                      ^7.9.0   ↓ lowest
      mobx-undecorate           ^7.9.0   ↓ lowest
      eslint-plugin-mobx        ^7.16.0   ↑ highest

 ✓ fixed Dependency @babel/preset-env has multiple versions defined in the workspace. multiple-dependency-versions
  ./packages
      mobx                      ^7.9.5   ↓ lowest
      mobx-undecorate           ^7.9.5   ↓ lowest
      eslint-plugin-mobx        ^7.16.4   ↑ highest

4 issues found (1 ⨯, 0 ⚠️, 3 ✓) across 5 packages in 3.20526775s.
 Note: use `-i` to ignore dependencies, `-r` to ignore rules, `-p` to ignore packages, and `--fix` to autofix fixable issues.

Code change checklist

  • Added/updated unit tests
  • Updated /docs. For new functionality, at least API.md should be updated
  • Verified that there is no significant performance drop (yarn mobx test:performance)

Copy link

changeset-bot bot commented Jul 1, 2024

⚠️ No Changeset found

Latest commit: a59ec22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mweststrate
Copy link
Member

This PR seems to cause some failures.

@vovsemenv vovsemenv closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants