Fix(mobx): Typescript pre-5.6 backwards compatibility #3960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 74bc622 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3 tasks
|
After some testing, I believe there is no value at all in shipping this vs using |
|
Yes, in general we just stick to TS latest since TS itself doesn't have any form of semantic versioning, so no worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've received some negative feedback w.r.t this patch #3935
mobx@6.13.4.as it breaks typescript backwards compatibility with versions before 5.6.
Apologies for any inconveniences this has caused, as far as I understand typescript isn't pinned to a specific version by design hence the updates being reported as a patch within previous changes, I am not entirely sure if this changeset makes much sense to include within the mobx package or it would be preferable to start specifying peer dependencies for typing.
Alternatively you can use
mobx@6.13.4+with older typescripts versions by adding the attached.d.tsfile to your project if you really need to type check dependencies.Going to quote mwestrate here
probably not worth it to add this patch but keen for feedback non the less.