Extract messages to separate file #GoodnessSquad #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 18, 2017 16:47
# Conflicts: # src/api/extendobservable.ts # src/api/whyrun.ts
5 tasks
dreisel
changed the title
capaj
approved these changes
Jan 21, 2017
A-gambit
requested changes
Jan 23, 2017
| ? "It is not allowed to create or change state outside an `action` when MobX is in strict mode. Wrap the current method in `action` if this state change is intended" | ||
| : "It is not allowed to change the state when a computed value or transformer is being evaluated. Use 'autorun' to create reactive functions with side-effects." | ||
| ? getMessage("m030") | ||
| :getMessage("m031") |
|
|
||
| export function getMessage(id : string) { | ||
| return messages[id]; | ||
| }; |
| "m036" : "It is not possible to get index atoms from arrays" , | ||
| "m037" : "\nHi there! I'm sorry you have just run into an exception.\n\nIf your debugger ends up here, know that some reaction (like the render() of an observer component, autorun or reaction)\nthrew an exception and that mobx caught it, to avoid that it brings the rest of your application down.\nThe original cause of the exception (the code that caused this reaction to run (again)), is still in the stack.\n\n However, more interesting is the actual stack trace of the error itself.\n Hopefully the error is an instanceof Error, because in that case you can inspect the original stack of the error from where it was thrown.\n See \`error.stack\` property, or press the very subtle \"(...)\" link you see near the console.error message that probably brought you here.\n That stack is more interesting than the stack of this console.error itself.\n\n If the exception you see is an exception you created yourself, make sure to use \`throw new Error(\"Oops\")\` instead of \`throw \"Oops\"\`,\n because the javascript environment will only preserve the original stack trace in the first form.\n\n You can also make sure the debugger pauses the next time this very same exception is thrown by enabling \"Pause on caught exception\".\n (Note that it might pause on many other, unrelated exception as well).\n\n If that all doesn't help you out, feel free to open an issue https://github.com/mobxjs/mobx/issues!\n", | ||
| "m038" : "Missing items in this list?\n 1. Check whether all used values are properly marked as observable (use isObservable to verify)\n 2. Make sure you didn't dereference values too early. MobX observes props, not primitives. E.g: use 'person.name' instead of 'name' in your computation.", | ||
|
|
| "m036" : "It is not possible to get index atoms from arrays" , | ||
| "m037" : "\nHi there! I'm sorry you have just run into an exception.\n\nIf your debugger ends up here, know that some reaction (like the render() of an observer component, autorun or reaction)\nthrew an exception and that mobx caught it, to avoid that it brings the rest of your application down.\nThe original cause of the exception (the code that caused this reaction to run (again)), is still in the stack.\n\n However, more interesting is the actual stack trace of the error itself.\n Hopefully the error is an instanceof Error, because in that case you can inspect the original stack of the error from where it was thrown.\n See \`error.stack\` property, or press the very subtle \"(...)\" link you see near the console.error message that probably brought you here.\n That stack is more interesting than the stack of this console.error itself.\n\n If the exception you see is an exception you created yourself, make sure to use \`throw new Error(\"Oops\")\` instead of \`throw \"Oops\"\`,\n because the javascript environment will only preserve the original stack trace in the first form.\n\n You can also make sure the debugger pauses the next time this very same exception is thrown by enabling \"Pause on caught exception\".\n (Note that it might pause on many other, unrelated exception as well).\n\n If that all doesn't help you out, feel free to open an issue https://github.com/mobxjs/mobx/issues!\n", | ||
| "m038" : "Missing items in this list?\n 1. Check whether all used values are properly marked as observable (use isObservable to verify)\n 2. Make sure you didn't dereference values too early. MobX observes props, not primitives. E.g: use 'person.name' instead of 'name' in your computation.", | ||
|
|
added 2 commits
January 23, 2017 18:21
This reverts commit 199f914.
|
Merged and will be part of next release! Probably needs some follow up to leverage this new mechanism during production builds, ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stage of issue: #653
I've extracted messages to a separate file in order to substitute them in the production build.
extracted 5.8kb of data.