Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: about-this-documentation.md #13

Merged
merged 10 commits into from
Apr 8, 2021
Merged

doc: about-this-documentation.md #13

merged 10 commits into from
Apr 8, 2021

Conversation

BlackHole1
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Feb 27, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mobx-docs-cn/zh-mobx-js-org/4szV3MygVebXEB3CNxwLpQ4fZ3Sf
✅ Preview: https://zh-mobx-js-org-git-fork-blackhole1-docs-translation-abou-00ec8f.vercel.app

@BlackHole1 BlackHole1 mentioned this pull request Feb 27, 2021
Closed
@iChenLei iChenLei added the 翻译中 文档正在翻译中 label Feb 27, 2021
@iChenLei iChenLei added 校对中 文档翻译完成，需要至少一个同学进行review校对 and removed 翻译中 文档正在翻译中 labels Mar 6, 2021
@iChenLei
Copy link
Member

iChenLei commented Mar 6, 2021

cc @ObservedObserver @wangjq4214 校对

@BlackHole1 @Neo42
Update docs/about-this-documentation.md
228f6bc 
Co-authored-by: Hao <giovannilance94@gmail.com>
BlackHole1 and others added 5 commits March 26, 2021 15:23
@BlackHole1 @Neo42
Update docs/about-this-documentation.md
7721e5b 
Co-authored-by: Hao <giovannilance94@gmail.com>
@BlackHole1 @Neo42
Update docs/about-this-documentation.md
0722df4 
Co-authored-by: Hao <giovannilance94@gmail.com>
@BlackHole1 @Neo42
Update docs/about-this-documentation.md
78ae1d9 
Co-authored-by: Hao <giovannilance94@gmail.com>
@BlackHole1 @Neo42
Update docs/about-this-documentation.md
af86f04 
Co-authored-by: Hao <giovannilance94@gmail.com>
@BlackHole1 @Neo42
Update docs/about-this-documentation.md
a39835c 
Co-authored-by: Hao <giovannilance94@gmail.com>
@BlackHole1
Copy link
Contributor Author

@Neo42 感谢你的校对

@iChenLei 因为这里使用 github 的《采纳建议》功能，所以会产生很多的 commit 记录，我不清楚这个项目合并 PR 的所采用的流程，不过我建议对此PR使用: Squash and Merge 或者 Rebase and Merge，以防止大量的无必要 commit 污染 git tree

@BlackHole1 @Neo42
Update docs/about-this-documentation.md
694c438 
Co-authored-by: Hao <giovannilance94@gmail.com>
@iChenLei
Copy link
Member

@BlackHole1 没关系 fork+pull request 默认squash

mobxjs/mobx#2641
mobxjs/mobx@28f8a11

你看这个PR 39个commits 合并PR之后在mobx仓库commit历史里只有一个的

@BlackHole1 @Neo42
Update docs/about-this-documentation.md
ec19e92 
Co-authored-by: Hao <giovannilance94@gmail.com>
@BlackHole1 @Neo42
Update docs/about-this-documentation.md
05414b5 
Co-authored-by: Hao <giovannilance94@gmail.com>
@BlackHole1
Copy link
Contributor Author

@BlackHole1 没关系 fork+pull request 默认squash

mobxjs/mobx#2641
mobxjs/mobx@28f8a11

你看这个PR 39个commits 合并PR之后在mobx仓库commit历史里只有一个的

好的

@Neo42
Copy link
Contributor

Neo42 commented Apr 8, 2021

@iChenLei LGTM

@iChenLei iChenLei merged commit e7a08eb into mobxjs:main Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neo42 Neo42 Neo42 left review comments

Assignees
No one assigned
Labels
校对中 文档翻译完成，需要至少一个同学进行review校对
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BlackHole1 @iChenLei @Neo42