Merge pull request #4849 from jedevc/fix-git-ref-to-broad

git: restrict definition of git ref to previous behavior
moby · Apr 17, 2024 · 3617025 · 3617025
2 parents b6bd514 + 8144ab8
commit 3617025
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/util/gitutil/git_ref.go b/util/gitutil/git_ref.go
@@ -69,7 +69,7 @@ func ParseGitRef(ref string) (*GitRef, error) {
 	} else {
 		remote, err = ParseURL(ref)
 		if errors.Is(err, ErrUnknownProtocol) {
-			remote, err = ParseURL("https://" + ref)
+			return nil, err
 		}
 		if err != nil {
 			return nil, err

diff --git a/util/gitutil/git_ref_test.go b/util/gitutil/git_ref_test.go
@@ -67,11 +67,8 @@ func TestParseGitRef(t *testing.T) {
 			},
 		},
 		{
-			ref: "custom.xyz/moby/buildkit.git",
-			expected: &GitRef{
-				Remote:    "https://custom.xyz/moby/buildkit.git",
-				ShortName: "buildkit",
-			},
+			ref:      "custom.xyz/moby/buildkit.git",
+			expected: nil,
 		},
 		{
 			ref:      "https://github.com/moby/buildkit",