Skip to content

Commit

Permalink
dockerfile: skip TestDockerfileInvalidCommand in gateway mode
Browse files Browse the repository at this point in the history
This test relies on specific output from the client which doesn't occur in this
mode since it ends up in the daemon logs instead.

Signed-off-by: Ian Campbell <ijc@docker.com>
  • Loading branch information
Ian Campbell committed Aug 2, 2018
1 parent a0ef049 commit 93156ac
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions frontend/dockerfile/dockerfile_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -773,6 +773,13 @@ func testDockerfileDirs(t *testing.T, sb integration.Sandbox, f *frontend) {
}

func testDockerfileInvalidCommand(t *testing.T, sb integration.Sandbox, f *frontend) {
if f.modeIs(ModeMasterGateway) {
// e.g. the "/bin/sh -c invalidcmd" check below fails
// because the string is in the daemon output not the
// buildctl output.
// TBD this should be fixed
t.Skipf("output goes to daemon not client in %q mode", f.mode)
}
t.Parallel()
dockerfile := []byte(`
FROM busybox
Expand Down

0 comments on commit 93156ac

Please sign in to comment.