lint: fix issues with go 1.18

nolint for strings.Title, we only have ASCII strings
and want to capitalize only the first character so no
need to worry about unicode

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>

frontend/dockerfile/instructions/parse.go

@@ -725,7 +725,7 @@ func errExactlyOneArgument(command string) error {
 }
 
 func errNoDestinationArgument(command string) error {
- return errors.Errorf("%s requires at least two arguments, but only one was provided. Destination could not be determined.", command)
+ return errors.Errorf("%s requires at least two arguments, but only one was provided. Destination could not be determined", command)
 }
 
 func errBadHeredoc(command string, option string) error {

hack/dockerfiles/lint.Dockerfile

@@ -1,6 +1,7 @@
 # syntax=docker/dockerfile-upstream:master
 
 FROM golang:1.18-alpine
+ENV GOFLAGS="-buildvcs=false"
 RUN apk add --no-cache gcc musl-dev yamllint
 RUN wget -O- -nv https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.45.0
 WORKDIR /go/src/github.com/moby/buildkit

solver/testutil/cachestorage_testsuite.go

@@ -387,7 +387,7 @@ func testWalkIDsByResult(t *testing.T, st solver.CacheKeyStorage) {
 func getFunctionName(i interface{}) string {
  fullname := runtime.FuncForPC(reflect.ValueOf(i).Pointer()).Name()
  dot := strings.LastIndex(fullname, ".") + 1
- return strings.Title(fullname[dot:])
+ return strings.Title(fullname[dot:]) //nolint:staticcheck
 }
 
 func rootKey(dgst digest.Digest, output solver.Index) digest.Digest {

util/resolver/retryhandler/retry.go

@@ -59,8 +59,8 @@ func retryError(err error) bool {
  if errors.Is(err, io.EOF) || errors.Is(err, syscall.ECONNRESET) || errors.Is(err, syscall.EPIPE) || errors.Is(err, net.ErrClosed) {
  return true
  }
- // catches TLS timeout or other network-related temporary errors
- if ne, ok := errors.Cause(err).(net.Error); ok && ne.Temporary() {
+ // catches TLS timeout
+ if ne, ok := errors.Cause(err).(net.Error); ok && ne.Timeout() {
  return true
  }
  // https://github.com/containerd/containerd/pull/4724

util/testutil/integration/run.go

@@ -210,7 +210,7 @@ func Run(t *testing.T, testCases []Test, opt ...TestOpt) {
 func getFunctionName(i interface{}) string {
  fullname := runtime.FuncForPC(reflect.ValueOf(i).Pointer()).Name()
  dot := strings.LastIndex(fullname, ".") + 1
- return strings.Title(fullname[dot:])
+ return strings.Title(fullname[dot:]) //nolint:staticcheck
 }
 
 var localImageCache map[string]map[string]struct{}