Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gateway exec: mount /sys and /sys/fs/cgroup into rootless runc #1716

Closed
coryb opened this issue Oct 4, 2020 · 2 comments · Fixed by #1774
Closed

gateway exec: mount /sys and /sys/fs/cgroup into rootless runc #1716

coryb opened this issue Oct 4, 2020 · 2 comments · Fixed by #1774
Assignees
@coryb
Labels
area/rootless rootless mode

Comments

@coryb
Copy link
Collaborator

coryb commented Oct 4, 2020

Work related to #749 left over from #1627

Currently rootless runc will panic when we exec into a container due to missing /sys within the container.
Issue on runc open here: opencontainers/runc#2573
Discussion thread here: #1627 (comment)

Current work around proposal is to mount /sys and /sys/fs/cgroup into the container. This was attempted in 4b51fbd but caused further test failures which needs to be diagnosed and resolved.
@coryb coryb added the area/rootless rootless mode label Oct 4, 2020
@coryb coryb self-assigned this Oct 5, 2020
coryb added a commit to coryb/buildkit that referenced this issue Oct 5, 2020
@coryb
[fix moby#1716] mount /sys and /sys/fs/cgroup for rootless
a564f0b
coryb added a commit to coryb/buildkit that referenced this issue Oct 5, 2020
@coryb
[fix moby#1716] mount /sys and /sys/fs/cgroup for rootless
b4b4b2c 
Signed-off-by: Cory Bennett <cbennett@netflix.com>
coryb added a commit to coryb/buildkit that referenced this issue Oct 5, 2020
@coryb
[fix moby#1716] mount /sys and /sys/fs/cgroup for rootless
c268ca3 
Signed-off-by: Cory Bennett <cbennett@netflix.com>
@coryb coryb mentioned this issue Oct 5, 2020
Merged
@tonistiigi
Copy link
Member

@coryb I see the upstream PR was merged. Does this require a vendor update or new runc release?

@coryb
Copy link
Collaborator Author

coryb commented Nov 2, 2020

I think we just need to update the RUNC_VERSION in Dockerfile for the integration tests to build runc, I will try to get a PR open for that Monday.

@coryb coryb linked a pull request Nov 2, 2020 that will close this issue
update runc used in integration tests so exec no longer panics #1774
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryb coryb

Labels
area/rootless rootless mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update runc used in integration tests so exec no longer panics coryb/buildkit
2 participants
@coryb @tonistiigi