[master] Add support for apparmor/selinux #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set's an apparmor profile on the OCI spec if one is configred on the worker. Adds selinux labels to containers (only added if selinux is enabled on the system). This assumes that the specified apparmor profile is already loaded on the system and does not try to load it or even check if it is loaded. SELinux support requires the `selinux` build tag to be added. Likewise, `runc` would require both the `apparmor` and `selinux` build tags. Signed-off-by: Brian Goff <cpuguy83@gmail.com> Vendored go-selinux to v1.8.0 Fixed tests Signed-off-by: Tibor Vass <tibor@docker.com> (cherry picked from commit 68bb095) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
@cpuguy83 @tiborvass PTAL |
tonistiigi
approved these changes
Feb 4, 2021
|
SELinux support seems pretty immature, I suggest making SELinux opt-in |
|
SGTM I quite possibly only tested selinux via Docker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this forward-ports this change to master from the v0.8 release branch (change was included in docker 20.10.3)
Set's an apparmor profile on the OCI spec if one is configred on the worker.
Adds selinux labels to containers (only added if selinux is enabled on the system).
This assumes that the specified apparmor profile is already loaded on the system and does not try to load it or even check if it is loaded.
SELinux support requires the
selinuxbuild tag to be added. Likewise,runcwould require both theapparmorandselinuxbuild tags.Signed-off-by: Brian Goff cpuguy83@gmail.com
Vendored go-selinux to v1.8.0
Fixed tests
Signed-off-by: Tibor Vass tibor@docker.com
(cherry picked from commit 68bb095)
Signed-off-by: Sebastiaan van Stijn github@gone.nl