test: fix mirror cache handling #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
AkihiroSuda
approved these changes
Jun 8, 2021
tonistiigi
commented
Jun 8, 2021
| @@ -216,6 +217,13 @@ func copyImagesLocal(t *testing.T, host string, images map[string]string) error | |||
| return err | |||
| } | |||
| } | |||
|
|
|||
| // already exists check | |||
There was a problem hiding this comment.
fyi, this shouldn't affect rate-limiting as HEAD requests are free, but no reason to recheck if tag has been updated in here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for the mirror handling in tests. When
TEST_KEEP_CACHE=1is set no requests should be made to external registries between invocations.Signed-off-by: Tonis Tiigi tonistiigi@gmail.com