Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to Go 1.19 #3022

Merged
merged 2 commits into from
Aug 25, 2022
Merged

update to Go 1.19 #3022

merged 2 commits into from
Aug 25, 2022

Conversation

crazy-max
Copy link
Member

also need to update golangci-lint to 1.48.0 for Go 1.19 support.

@crazy-max
Copy link
Member Author

First time I see tests timing out 🤔 https://github.com/moby/buildkit/runs/7788531022?check_suite_focus=true#step:6:1024

coverage: 64.0% of statements
panic: test timed out after 20m0s

@crazy-max crazy-max force-pushed the go-1.19 branch 2 times, most recently from 149ef7d to a7b4b88 Compare August 11, 2022 19:04
@crazy-max
Copy link
Member Author

First time I see tests timing out 🤔 https://github.com/moby/buildkit/runs/7788531022?check_suite_focus=true#step:6:1024

Hum actually it's not linked to the update to Go 1.19. Latest build on master also failed on windows runner: https://github.com/moby/buildkit/runs/7794652775?check_suite_focus=true#step:6:140

And some integration tests on linux runners for the past few days like https://github.com/moby/buildkit/runs/7736178912?check_suite_focus=true#step:6:1070

Maybe there is some disruption with the infra hosting the runners?

@crazy-max crazy-max marked this pull request as ready for review August 11, 2022 23:39
@vangarp
Copy link
Contributor

vangarp commented Aug 16, 2022

@crazy-max are you planning to push this? If not do you mind approving #3023?

@AkihiroSuda
Copy link
Member

@tonistiigi PTAL

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@tonistiigi tonistiigi merged commit c07a656 into moby:master Aug 25, 2022
@crazy-max crazy-max deleted the go-1.19 branch August 25, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants