[v0.10] cherry-picks for v0.10.4 #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tonistiigi
commented
Aug 22, 2022
•
tonistiigi
commented
- executor/oci: replace deprecated types.IP #2858
- Update gopkg.in/yaml.v3 to v3.0.0 #2876
- fix cancellation error not being detected and erroneously cached #2926
- dockerfile: fix created timestamp #2920
- Pass platform arg for stage state to ContextByName #2990
- Add config, logging for healthcheck #2998
- frontend: make sure interactive containers are released on disconnect #3025
- solver: forward nil return value from sharedOp.Exec #3043
Images built using docker-image:// passed through buildkit named contexts had the wrong Image.Created timestamp, using the timestamp from the used image, instead of the current datetime. To fix, we perform the same input cleanup as in Dockerfile2LLB, and explicitly set the timestamp to nil. Signed-off-by: Justin Chadwell <me@jedevc.com> (cherry picked from commit 63b2e01) Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Justin Chadwell <me@jedevc.com> (cherry picked from commit 59a295b) Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Fixes image build contexts not respecting the platform specified in the Dockerfile `FROM --platform` argument. Before this change buildkit always resolves images using the target platform, but `FROM` may specifiy something else (such as $BUILDPLATFORM). Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit cc6137c) Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Even when client does not release a container it should be released automatically on disconnect. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 80aa8b4)
Signed-off-by: Corey Larson <corey@earthly.dev> Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit b637861) Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Exec could sometimes return nil, which would then result in a segmentation fault, as the code attempts to access a field in the nil result to return. This patch introduces a sanity check before accessing any parts of the field. Signed-off-by: Justin Chadwell <me@jedevc.com> (cherry picked from commit c58f128) Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit dfb08e3) Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com> (cherry picked from commit df16694) Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 6644f16) Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
AkihiroSuda
approved these changes
Aug 22, 2022
cpuguy83
approved these changes
Aug 22, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.