[0.10 backport] integration: skip for dockerd #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> (cherry picked from commit c175c93) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> (cherry picked from commit 54bcf4b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> (cherry picked from commit 07e7f32) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> (cherry picked from commit e870da7) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
crazy-max
approved these changes
Oct 20, 2022
thaJeztah
commented
Oct 20, 2022
| @@ -5508,6 +5508,7 @@ RUN echo hello | |||
| } | |||
|
|
|||
| func testNamedImageContextTimestamps(t *testing.T, sb integration.Sandbox) { | |||
| integration.SkipIfDockerd(t, sb, "direct push") | |||
There was a problem hiding this comment.
Looks like TestNamedImageContextPlatform is also failing; probably needs a skip added?
There was a problem hiding this comment.
Split commits in #3206 so you can cherry pick
tonistiigi
approved these changes
Oct 20, 2022
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> (cherry picked from commit 5505af9) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
0.10_test_skips
branch
from
5276a2d to
b34da50
Compare
|
all green! bringing this in 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports: