Don't support cgroupns on cgroups v1 #4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes moby#4108 Signed-off-by: Mark Yen <mark.yen@suse.com>
AkihiroSuda
reviewed
Oct 4, 2023
executor/oci/spec_linux.go
Outdated
| @@ -150,9 +150,13 @@ func getTracingSocket() string { | |||
|
|
|||
| func cgroupNamespaceSupported() bool { | |||
There was a problem hiding this comment.
Suggested change
| func cgroupNamespaceSupported() bool { | |
| func cgroupV2NamespaceSupported() bool { |
There was a problem hiding this comment.
Also please add comment lines to explain the background for this
mook-as
added a commit
to mook-as/buildkit
that referenced
this pull request
Oct 4, 2023
This responds to review feedback from moby#4308 (review) Signed-off-by: Mark Yen <mark.yen@suse.com>
AkihiroSuda
reviewed
Oct 4, 2023
| func cgroupV2NamespaceSupported() bool { | ||
| // Check if cgroups v2 namespaces are supported. Trying to do cgroup | ||
| // namespaces with cgroups v1 results in EINVAL when we encounter a | ||
| // non-standard hierarchy. |
There was a problem hiding this comment.
Needs a link to the issue ticket
This responds to review feedback from moby#4308 (review) Signed-off-by: Mark Yen <mark.yen@suse.com>
mook-as
force-pushed
the
4108-alpine-cgroups
branch
from
24daf29 to
f9ccb09
Compare
AkihiroSuda
approved these changes
Oct 4, 2023
|
I think we can merge this but we would still like to see the original issue to be analyzed properly |
tonistiigi
approved these changes
Oct 11, 2023
This was added in #4003 and released in v0.12 that should be the regression point. |
jedevc
approved these changes
Oct 13, 2023
jedevc
pushed a commit
to jedevc/buildkit
that referenced
this pull request
Oct 13, 2023
This responds to review feedback from moby#4308 (review) Signed-off-by: Mark Yen <mark.yen@suse.com> (cherry picked from commit f9ccb09) Signed-off-by: Justin Chadwell <me@jedevc.com>
nxmatic
pushed a commit
to nxmatic/buildkit
that referenced
this pull request
Dec 3, 2023
This responds to review feedback from moby#4308 (review) Signed-off-by: Mark Yen <mark.yen@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly fixes #4108.
Note that I have no idea what I'm doing; I'm basing the new stat call on what the tests in #4003 are doing (on the assumption that if it is not compatible with the test, it was probably what broke my use cases too). Any suggestions on what to do instead (or even just PRs that replace this one) very welcome.