Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filesync: append metadata for CopyToCaller #4560

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

jedevc
Copy link
Member

@jedevc jedevc commented Jan 16, 2024

This was a regression introduced in #4134 when editing the implementation of CopyFileWriter and CopyToCaller to support multiplexed imports.

Identical in style to #4049, we need to ensure that CopyToCaller also doesn't overwrite the provided metadata, but instead appends to it.

This was a regression introduced in 81b4762.

Similar in style to 4b56395, we need to
ensure that CopyToCaller also doesn't overwrite the provided metadata,
but instead appends to it.

Signed-off-by: Justin Chadwell <me@jedevc.com>
@tonistiigi tonistiigi merged commit 0060e25 into moby:master Jan 16, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants