Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/converter: fix diffID computation #4807

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

AkihiroSuda
Copy link
Member

The archive reader was not fully consumed on computating the diffID.

Fix #4805

Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More questions

util/converter/converter.go Outdated Show resolved Hide resolved
The archive reader was not fully consumed on computating the diffID.

Fix issue 4805

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda requested a review from ktock April 2, 2024 01:11
@AkihiroSuda AkihiroSuda merged commit cbb116d into moby:master Apr 2, 2024
72 checks passed
@AkihiroSuda AkihiroSuda added this to the v0.13.2 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rewrite-timestamp still rewrites base image layers (for some base images)
4 participants