Fix content not found with push=true,rewrite-timestamp=true
#5008
Conversation
AkihiroSuda
force-pushed
the
fix-4793
branch
2 times, most recently
from
da046ee
to
8a7cb9c
Compare
| if opts.RewriteTimestamp { | ||
| annotations := map[digest.Digest]map[string]string{} | ||
| addAnnotations(annotations, *desc) | ||
| // e.pushImage cannot be used because src ref does not point to the rewritten image |
There was a problem hiding this comment.
What's the context behind removing this condition
There was a problem hiding this comment.
The comment seems outdated and the CI has no complaint on removing the code
| dockerfile: `FROM amd64/debian:bullseye-20230109 AS dangling | ||
| FROM amd64/debian:bullseye-20230109-slim | ||
| `, | ||
| expectedDigest: "sha256:eeba8ef81dec46359d099c5d674009da54e088fa8f29945d4d7fb3a7a88c450e", |
There was a problem hiding this comment.
Could we get these digests computed with digest.FromBytes() . Atm. it is hard/impossible to understand what is the expected result or where this digest is coming from.
There was a problem hiding this comment.
We can't know the manifest digest until building it
There was a problem hiding this comment.
Well, you need to know the contents of the manifest if you know its digest here.
There was a problem hiding this comment.
I think it is not specific to this PR and can be revisited in a separate issue/PR?
Fix issue 4793 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
|
@AkihiroSuda is this for v0.14.1? |
Fix #4793