git: fix pulling commit SHA only referenced from a tag #5072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On commit SHA input we currently do a full fetch of remote so we can pick up the commit by SHA later. This only pulls in tags that are also part of branches. Extra flag is needed to also get the tags that are not part of branches. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
git-commit-tags-fetch
branch
from
2b4ea10
to
dff03a2
Compare
crazy-max
approved these changes
Jun 22, 2024
AkihiroSuda
reviewed
Jun 23, 2024
| @@ -635,6 +714,7 @@ func setupGitRepo(t *testing.T) gitRepoFixture { | |||
| "git add -A", | |||
| "git commit -m withsub", | |||
| "git checkout master", | |||
| // "git log --oneline --graph --decorate=full --all", | |||
There was a problem hiding this comment.
Is this a leftover debug print?
There was a problem hiding this comment.
This line can be used to update the comment showing the git structure in line 686 if updates are made
AkihiroSuda
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On commit SHA input we currently do a full fetch of remote so we can pick up the commit by SHA later. This only pulls in tags that are also part of branches. Extra flag is needed to also get the tags that are not part of branches.