errdefs: detect certain sycall errors as internal #5182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
commented
Jul 23, 2024
errdefs/internal.go
Outdated
|
|
||
| var systemErrors = []syscall.Errno{ | ||
| syscall.EIO, // I/O error | ||
| syscall.ENOMEM, // Out of memory |
There was a problem hiding this comment.
@silvin-lubecki I'm not sure if we should mark ENOMEM and ENOSPC as internal like others or maybe some ResourceExhausted code would make more sense. Technically these are likely caused by too much usage from user, not internal bugs.
There was a problem hiding this comment.
I agree with you @tonistiigi. I like what you suggested with the specific error code, it allows some latitude to interpret it as user or internal error 👍
There was a problem hiding this comment.
Moved ENOMEM and ENOSPC to ResourceExhausted code instead.
tonistiigi
force-pushed
the
internal-syscall-err
branch
from
977cd82
to
d90b759
Compare
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
internal-syscall-err
branch
from
d90b759
to
d9a9a4d
Compare
tonistiigi
added a commit
to tonistiigi/buildkit
that referenced
this pull request
Aug 16, 2024
If container exits with error and has invoked OOMKiller mark the origin error as ENOMEM so that it can be detected on the client side. gRPC will set ENOMEM as codes.ResouceExhausted based on moby#5182 Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
added a commit
to tonistiigi/buildkit
that referenced
this pull request
Aug 16, 2024
If container exits with error and has invoked OOMKiller mark the origin error as ENOMEM so that it can be detected on the client side. gRPC will set ENOMEM as codes.ResouceExhausted based on moby#5182 Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
|
PTAL @silvin-lubecki 🙏 |
crazy-max
approved these changes
Sep 4, 2024
daghack
pushed a commit
to daghack/buildkit
that referenced
this pull request
Sep 19, 2024
If container exits with error and has invoked OOMKiller mark the origin error as ENOMEM so that it can be detected on the client side. gRPC will set ENOMEM as codes.ResouceExhausted based on moby#5182 Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #5181depends on #5163