-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Experimental Rulechecks #5213
Conversation
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
c00dd4a
to
587b081
Compare
I also think we should add something to the buildkit/frontend/dockerfile/linter/docs/_index.md Lines 32 to 35 in 27efea4
|
587b081
to
babcd06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
babcd06
to
a62980e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but we should still make sure we can remove the experimental opt-in from the CopyIgnoredFile
rule with the next release.
resolves #5176
Implements the feature and updates the
CopyIgnoredFile
rule check to be experimental through the new proposal.