Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Experimental Rulechecks #5213

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

daghack
Copy link
Collaborator

@daghack daghack commented Aug 5, 2024

resolves #5176

Implements the feature and updates the CopyIgnoredFile rule check to be experimental through the new proposal.

Signed-off-by: Talon Bowler <talon.bowler@docker.com>
@daghack daghack self-assigned this Aug 5, 2024
@daghack daghack marked this pull request as draft August 5, 2024 06:38
@daghack daghack marked this pull request as ready for review August 5, 2024 15:14
@crazy-max crazy-max added this to the v0.16.0 milestone Aug 6, 2024
@daghack daghack force-pushed the experimental-rule-checks branch 2 times, most recently from c00dd4a to 587b081 Compare August 8, 2024 16:09
@dvdksn
Copy link
Collaborator

dvdksn commented Aug 8, 2024

I also think we should add something to the _index.md listing page to indicate which checks are experimental

<tr>
<td><a href="./{{ .PageName }}/">{{ .Name }}</a></td>
<td>{{ .Description }}</td>
</tr>

Copy link
Collaborator

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daghack daghack requested a review from crazy-max August 9, 2024 16:12
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but we should still make sure we can remove the experimental opt-in from the CopyIgnoredFile rule with the next release.

@tonistiigi tonistiigi merged commit 36f076d into moby:master Aug 13, 2024
80 checks passed
@daghack daghack deleted the experimental-rule-checks branch August 14, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Add experimental ruleset in lint rule check directive.
4 participants