Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bklog: always enable trace id if it exists #5315

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

jsternberg
Copy link
Collaborator

Previous version of the detect package would only enable trace ids in the build log if tracing was in use. For practical purposes, there was always a tracer in use (either the recorder which was always enabled or one of the detected tracers).

When this package was refactored, the call to enable the trace id was accidentally removed.

This removes the option to enable or disable the trace id from the log and instead just always enables it since this was the behavior previously.

Fixes #5310.

Previous version of the detect package would only enable trace ids in
the build log if tracing was in use. For practical purposes, there was
always a tracer in use (either the recorder which was always enabled or
one of the detected tracers).

When this package was refactored, the call to enable the trace id was
accidentally removed.

This removes the option to enable or disable the trace id from the log
and instead just always enables it since this was the behavior
previously.

Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
@tonistiigi tonistiigi merged commit c9d08dd into moby:master Sep 9, 2024
92 checks passed
@jsternberg jsternberg deleted the trace-id-in-log branch September 10, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trace ID not printed in debug mode after upgrading to v0.15.1
3 participants