apicaps: record the correct caps when constructing a CapSet #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to capture `c` within the loop, otherwise all of the entries of `m` end up pointing to the same thing, which is the last cap in `range caps`. The symptom was that all caps were enabled/disabled based on the last cap's setting and not their own. Add a test for this. Signed-off-by: Ian Campbell <ijc@docker.com>
tonistiigi
approved these changes
Jul 25, 2018
|
@ijc Thanks! |
|
@tonistiigi it occurred to me this morning that since we are now copying each cap anyway perhaps (shame there's no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to capture
cwithin the loop, otherwise all of the entries ofmendup pointing to the same thing, which is the last cap in
range caps.The symptom was that all caps were enabled/disabled based on the last cap's
setting and not their own.
Add a test for this.
Signed-off-by: Ian Campbell ijc@docker.com
Noticed when adding a cap for #533 that the test didn't fail when I disabled it...