-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v0.17] Dependency updates #5462
Conversation
tonistiigi
commented
Oct 28, 2024
•
edited
Loading
edited
- some patch release bumps
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Brings fix for CVE-2024-35255 Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
hcsshim v0.12.5 and containerd 1.7.23 are incompatible : |
@AkihiroSuda Any ideas? |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
f3e5281
to
c9a25c4
Compare
Perhaps https://github.com/containernetworking/plugins lacks an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- compose-go v2.4.1
This one is buildx only right?
Reverted the CNI bump as well. Not great as this will mean that CVE scanners will mark the release for all the old Go issues. Nothing too obvious in CNI changelog. |
ARG RUNC_VERSION=v1.1.14 | ||
ARG CONTAINERD_VERSION=v1.7.22 | ||
ARG RUNC_VERSION=v1.1.15 | ||
ARG CONTAINERD_VERSION=v1.7.23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep 1.7.22 if we can't vendor the go module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They don't need to be the same. We are still compatible with v1.7.23 daemon.
For containerd 1.7.23 you either need to stay on 0.11 or you need to update to hcsshim v0.12.8, but that comes with a whole lot of dependency updates; see the PRs linked from this one; go modules won't do that update, because v0.12.x (any v0.12.x version) is higher than v0.11 (what containerd v1.7.23 uses), so it considers it high enough. In moby we wanted to stay on v0.11 for the 27.x branch, and only updated hcsshim to v0.12 for master. So BuildKit can decide to either revert to v0.11, and keep v0.12 for the next release (together with moby v28.0), or do all the other updates as well. |