Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.17] Dependency updates #5462

Merged
merged 10 commits into from
Oct 28, 2024
Merged

Conversation

tonistiigi
Copy link
Member

@tonistiigi tonistiigi commented Oct 28, 2024

- Containerd v1.7.22
- Runc v1.1.15
- docker/docker v27.3.1
- docker/cli v27.3.1
- OTEL 1.21.0
- grpc v1.66.2
- compose-go v2.4.1
- hcsshim v0.12.5
  • some patch release bumps

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Brings fix for CVE-2024-35255

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@github-actions github-actions bot added area/project area/dependencies Pull requests that update a dependency file labels Oct 28, 2024
@tonistiigi
Copy link
Member Author

hcsshim v0.12.5 and containerd 1.7.23 are incompatible :rage1: :

@tonistiigi
Copy link
Member Author

    sandbox.go:138: buildkitd: plugin type="loopback" failed (add): interrupted system call
    sandbox.go:138: CNI setup error

@AkihiroSuda Any ideas?

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@AkihiroSuda
Copy link
Member

failed (add): interrupted system call

Perhaps https://github.com/containernetworking/plugins lacks an EINTR retry loop?

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • compose-go v2.4.1

This one is buildx only right?

@tonistiigi
Copy link
Member Author

Reverted the CNI bump as well. Not great as this will mean that CVE scanners will mark the release for all the old Go issues. Nothing too obvious in CNI changelog.

ARG RUNC_VERSION=v1.1.14
ARG CONTAINERD_VERSION=v1.7.22
ARG RUNC_VERSION=v1.1.15
ARG CONTAINERD_VERSION=v1.7.23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep 1.7.22 if we can't vendor the go module?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They don't need to be the same. We are still compatible with v1.7.23 daemon.

@tonistiigi tonistiigi merged commit d09c1e2 into moby:master Oct 28, 2024
92 checks passed
@thaJeztah
Copy link
Member

hcsshim v0.12.5 and containerd 1.7.23 are incompatible :rage1: :

For containerd 1.7.23 you either need to stay on 0.11 or you need to update to hcsshim v0.12.8, but that comes with a whole lot of dependency updates; see the PRs linked from this one;

go modules won't do that update, because v0.12.x (any v0.12.x version) is higher than v0.11 (what containerd v1.7.23 uses), so it considers it high enough.

In moby we wanted to stay on v0.11 for the 27.x branch, and only updated hcsshim to v0.12 for master.

So BuildKit can decide to either revert to v0.11, and keep v0.12 for the next release (together with moby v28.0), or do all the other updates as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants