Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for IsCommitSHA function #5476

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add test for IsCommitSHA function #5476

wants to merge 1 commit into from
+37 −0

Conversation

tianon
Copy link
Member

@tianon tianon commented Oct 31, 2024

See:

tianon
tianon commented Oct 31, 2024
View reviewed changes
util/gitutil/git_commit_test.go
"zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz", // 64 invalid characters
"01234567890abcdef01234567890abcdef01234567890abcdef01234567890abc", // 65 valid characters

// TODO: add SHA-256 support and move this up to the "true" section
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I debated - should I add a link to #5471 here, or leave it as-is?

@tonistiigi
Copy link
Member

@tianon You forgot DCO

@tianon
Add test for IsCommitSHA function
af71927 
Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
@tianon
Copy link
Member Author

tianon commented Nov 4, 2024

Dohh 🤦

fixed

@thompson-shaun thompson-shaun added this to the v0.18.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees
No one assigned
Labels
area/testing area/util
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tianon @tonistiigi @thompson-shaun