update to go 1.23 #5492
update to go 1.23 #5492
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
github-actions
bot
added
area/dockerfile
area/hack
Dockerfile
Outdated
| @@ -17,7 +17,7 @@ ARG AZURITE_VERSION=3.18.0 | |||
| ARG GOTESTSUM_VERSION=v1.9.0 | |||
| ARG DELVE_VERSION=v1.22.1 | |||
There was a problem hiding this comment.
Do we need to update this one? I recall we had to update it in moby at some point due to incompatibility with go versions; moby/moby#48497
current version looks to be 1.23.1; https://github.com/go-delve/delve/releases/tag/v1.23.1
There was a problem hiding this comment.
I also went looking for other related things, and was confused for a bit for the gopls version, because there's to v0.26, but it looks like we're using the golang.org/x/tools tag instead of the gopls/vXXX tags;
Wondering if we should change that (https://github.com/golang/tools/releases/tag/gopls%2Fv0.16.2)
There was a problem hiding this comment.
Do we need to update this one?
Ah yes we should, there are fixes for Go 1.23 in latest stable, let me do that.
but it looks like we're using the
golang.org/x/toolstag instead of thegopls/vXXXtags
I don't think we want specifically the gopls tool https://github.com/golang/tools/tree/master/gopls but tool repo to handle extra analyzers. Maybe GOTOOLS_VERSION would be a better name. cc @tonistiigi
There was a problem hiding this comment.
Maybe GOTOOLS_VERSION would be a better name
That works as well 😅 I was just a bit confused "what's this version?" 😂
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
|
Need to verify that qemu is good from #5255 (comment) |
Has been fixed in 1.23.3: golang/go#68976 (comment) (https://go-review.googlesource.com/c/go/+/617716) |
No description provided.