[v0.18] cherry-picks for v0.18.2 #5601
Merged
+254
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tonistiigi
commented
Dec 16, 2024
tonistiigi
commented
- llb: avoid concurrent map write on parallel marshal #5577
- Dockerfile: update runc binary to v1.2.3 #5588
- dockerfile: add regression test for parallel cache mounts #5590
- dockerfile: fix onbuild propagation for child stages #5593
- dockerfile: fix named context replacement for child stages #5596
- hack: remove loong64 validation in archutil #5600
- xx v1.6.1 update
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 9a2d75f)
Brings in support for Alpine 3.21 that has been embedded into latest golang images. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Calling marshal changes the internal state of the op, for example addCap() helper adds capability constraints. These can race with same map being read by another Marshal call. Locking the Marshal function itself also makes sure that the cache is not recomputed in this case. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 30413b5)
This is the third patch release of the 1.2.z release branch of runc. It primarily fixes some minor regressions introduced in 1.2.0. - Fixed a regression in use of securejoin.MkdirAll, where multiple runc processes racing to create the same mountpoint in a shared rootfs would result in spurious EEXIST errors. In particular, this regression caused issues with BuildKit. - Fixed a regression in eBPF support for pre-5.6 kernels after upgrading Cilium's eBPF library version to 0.16 in runc. full diff: opencontainers/runc@v1.2.2...v1.2.3 release notes: https://github.com/opencontainers/runc/releases/tag/v1.2.3 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 6638c88)
Checks for mkdir bug that was fixed in runc 1.2.3 Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit ee0438b)
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 8bf1d78)
Fixes bug that didn't allow named context replacement for stages that were inherited from another stage. This is a regression from Dockerfile 1.11 ONBUILD changes where code was changed to call init() later to allow ONBUILD rules to change the dependency list of a stage. Calling this reinit caused the child stage to pick up the its state from the parent stage in Dockerfile again. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 4c8bd43)
github-actions
bot
added
area/dockerfile
area/project
area/llb
area/testing
area/hack
There was a problem hiding this comment.
Copilot reviewed 5 out of 17 changed files in this pull request and generated no comments.
Files not reviewed (12)
- Dockerfile: Language not supported
- frontend/dockerfile/cmd/dockerfile-frontend/Dockerfile: Language not supported
- hack/dockerfiles/archutil.Dockerfile: Language not supported
- hack/dockerfiles/lint.Dockerfile: Language not supported
- client/llb/definition.go: Evaluated as low risk
- client/llb/diff.go: Evaluated as low risk
- client/llb/merge.go: Evaluated as low risk
- client/llb/llbbuild/llbbuild.go: Evaluated as low risk
- client/llb/exec.go: Evaluated as low risk
- client/llb/source.go: Evaluated as low risk
- client/llb/fileop.go: Evaluated as low risk
- frontend/dockerfile/dockerfile2llb/convert.go: Evaluated as low risk
crazy-max
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.