fix: docs: windows: enhance the CNI setup instructions #5694
+31
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous instructions had a slight mistake where the CNI version was similar to the CNI plugin Version. At that time, that was true, we had 0.3.0. However, the latest plugin version is 0.3.1 and supports upto CNI v 1.0.0. Fix the installation scripts to have `$cniVersion` and `$cniPluginVersion` as separate variables. Also add script to set up HNS Network on WS2019 when it is not already available by default, like in the rest of the SKUs WS2022+, after enabling Hyper-V. Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
tonistiigi
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous instructions had a slight mistake where the CNI version was similar to the CNI plugin Version. At that time, that was true, we had 0.3.0. However, the latest plugin version is 0.3.1 and supports upto CNI v 1.0.0.
Fix the installation scripts to have
$cniVersionand$cniPluginVersionas separate variables.Also add script to set up HNS Network on WS2019 when it is not already available by default, like in the rest of the SKUs WS2022+, after enabling Hyper-V.