runcexecutor: allow disabling subreaper #583
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When other daemons such as dockerd set subreaper, there can be issues.
This allows those daemons to disable subreaping if they need to.
Hopefully this commit either gets reverted soon or will have a valid
concrete usecase, as the investigation continues on
moby/moby#37676
Signed-off-by: Tibor Vass tibor@docker.com
cc @AkihiroSuda @ijc