runcexecutor: allow disabling subreaper #583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When other daemons such as dockerd set subreaper, there can be issues. This allows those daemons to disable subreaping if they need to. Hopefully this commit either gets reverted soon or will have a valid concrete usecase, as the investigation continues on moby/moby#37676 Signed-off-by: Tibor Vass <tibor@docker.com>
AkihiroSuda
approved these changes
Aug 20, 2018
|
Seems OK to me, and is easily enough to revert. I don't think the comment about the interface stability is particularly necessary since that sub-package is not something which buildkit makes any guarantees about in the first place. The only versioning guarantees I know about are for e.g. the gRPC gateway interfaces and the LLB (such as #465) and some of the Dockerfile frontend functionality (see #528). |
|
This is wrong and thus useless. Michael's PR #584 solves my problem better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When other daemons such as dockerd set subreaper, there can be issues.
This allows those daemons to disable subreaping if they need to.
Hopefully this commit either gets reverted soon or will have a valid
concrete usecase, as the investigation continues on
moby/moby#37676
Signed-off-by: Tibor Vass tibor@docker.com
cc @AkihiroSuda @ijc