[0.25] cherry-picks for v0.25.1 #6271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple exports run in parallel inline cache exporting can run for each of them into the same cache exporter instance. Inline cache exporter can only be invoked multiple times sequentially. There is a 'reset()` call after every invocation that completely switches out the internal cache chains collector. Before v0.25 this caused some corruption in inline cache (or some unknown error). Since v0.25 this case is likely to trigger internal consistency check error and fail the build. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
github-actions
bot
added
area/hack
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Don't fail whole cache export on subbranch error. This behavior changed in v0.25, but while before error was not returned, the cache chains were either too agressively dropped or the whole exported cache chain got corrupted. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
v0.25_picks_0.25.1
branch
from
ca19e00 to
3b5fb90
Compare
github-actions
bot
added
area/dockerfile
area/testing
area/client
area/frontend
and removed
area/dependencies
Member
|
I think we can skip #6273 . It is safe, but I needed to move code around too much for a patch release. |
Member
Author
Ok I was thinking it would be helpful to run tests on moby Edit: We can use another ref to run buildkit tests on moby if we want to. |
While the custom fields used embedded Go struct field, this does not work for map types and needs custom JSON marshaller to make sure custom fields appear without wrapper. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
crazy-max
force-pushed
the
v0.25_picks_0.25.1
branch
from
028587d to
c35e14d
Compare
tonistiigi
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of: