Various fixes #313
Merged
Various fixes #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…21-054) This is backport of what is done in bhyve Signed-off-by: Frederic Dalleau <frederic.dalleau@docker.com>
…2021-055) This is a backport of what is done in bhyve. Signed-off-by: Frederic Dalleau <frederic.dalleau@docker.com>
Signed-off-by: Frederic Dalleau <frederic.dalleau@docker.com>
…1-057) Signed-off-by: Frederic Dalleau <frederic.dalleau@docker.com>
fredericdalleau
force-pushed
the
various-fixes
branch
from
dee87b4 to
af5eba2
Compare
This was referenced Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series add some fixes for various cases that have been reported that allow the guest to trigger a crash of the virtual machine.
The first two are NULL pointer dereference and are already handled in bhyve.
https://cgit.freebsd.org/src/tree/usr.sbin/bhyve/virtio.c#n606
https://cgit.freebsd.org/src/tree/usr.sbin/bhyve/virtio.c#n725
The other two are unhandled returned errors in vq_getchain. For now, trace and return as in pci_vt9p_notify.
Let me know what you think.