ndots: produce error on negative numbers

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
moby · Jun 28, 2018 · cfa9afd · cfa9afd
1 parent 5586e22
commit cfa9afd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/sandbox_dns_unix.go b/sandbox_dns_unix.go
@@ -374,6 +374,8 @@ dnsOpt:
 						// if the user sets ndots, use the user setting
 						sb.ndotsSet = true
 						break dnsOpt
+					} else {
+						return fmt.Errorf("invalid number for ndots option: %v", num)
 					}
 				}
 			}

diff --git a/service_common_test.go b/service_common_test.go
@@ -103,4 +103,10 @@ func TestDNSOptions(t *testing.T) {
 	require.NoError(t, err)
 	err = sb2.(*sandbox).rebuildDNS()
 	require.EqualError(t, err, "invalid number for ndots option: foobar")
+
+	sb2.(*sandbox).config.dnsOptionsList = []string{"ndots:-1"}
+	err = sb2.(*sandbox).setupDNS()
+	require.NoError(t, err)
+	err = sb2.(*sandbox).rebuildDNS()
+	require.EqualError(t, err, "invalid number for ndots option: -1")
 }